NCBM/plyngent
1
0
Fork 0
mirror of https://github.com/NCBM/plyngent.git synced 2026-11-07 15:37:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

core/tools: change ask_user_choice and ask_user_form params from JSON strings to typed lists

Browse Source
This commit is contained in:
worldmozara
2026-07-29 01:42:00 +08:00
parent f5b566b371
commit ef3594ad62
3 changed files with 57 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_tools/test_chat_tools.py
+27 -6
View File
@@ -25,7 +25,7 @@ async def test_choose_user_tool_index() -> None:
json.dumps(
{
"question": "Pick",
"options": json.dumps(["alpha", "beta"]),
"options": ["alpha", "beta"],
"allow_custom": False,
}
),
@@ -33,23 +33,44 @@ async def test_choose_user_tool_index() -> None:
assert out == "alpha"
async def test_choose_user_bad_options() -> None:
async def test_choose_user_dict_options() -> None:
backend = ScriptedBackend(["1"])
with temporary_backend(backend):
registry = ToolRegistry([choose_user])
out = await registry.execute(
"ask_user_choice",
json.dumps(
{
"question": "Pick",
"options": [{"label": "yes", "description": "affirm"}],
}
),
)
assert out == "yes"
async def test_choose_user_invalid_options() -> None:
registry = ToolRegistry([choose_user])
out = await registry.execute(
"ask_user_choice",
json.dumps({"question": "Pick", "options": "not-json"}),
json.dumps({"question": "Pick", "options": [42]}),
)
assert out.startswith("error:")
assert "error" in out
async def test_form_user_tool() -> None:
backend = ScriptedBackend(["ncbm"], confirms=[True])
fields = json.dumps([{"name": "user", "prompt": "User?"}])
with temporary_backend(backend):
registry = ToolRegistry([form_user])
out = await registry.execute(
"ask_user_form",
json.dumps({"title": "Setup", "fields": fields, "confirm_submit": True}),
json.dumps(
{
"title": "Setup",
"fields": [{"name": "user", "prompt": "User?"}],
"confirm_submit": True,
}
),
)
assert json.loads(out) == {"user": "ncbm"}